Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that tuple_size is defined #473

Merged
merged 2 commits into from
May 3, 2024
Merged

Ensure that tuple_size is defined #473

merged 2 commits into from
May 3, 2024

Conversation

miscco
Copy link
Contributor

@miscco miscco commented May 3, 2024

Some compilers have issues trying to instantiate it too early. We can work around this by adding another SFINAE condition.

@miscco
Ensure that tuple_size is defined
0d968f3 
Some compilers have issues trying to instantiate it too early. We can work around this by adding another SFINAE condition.
miscco
miscco commented May 3, 2024
View reviewed changes
Copy link
Contributor Author

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up when building cuDF with latest CCCL ToT

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel added the type: improvement Improvement / enhancement to an existing function label May 3, 2024
PointKernel
PointKernel approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@PointKernel PointKernel merged commit 6923b3b into NVIDIA:dev May 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@sleeepyjack sleeepyjack Awaiting requested review from sleeepyjack sleeepyjack is a code owner

Assignees
No one assigned
Labels
type: improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miscco @PointKernel